Seeking help - Refactoring midi controller device drivers for Vangelis

[jofemodo]

@LFO

chains.

I put the disable_note_filter into each mode switch area except for note mode which has the enable function.

it’s just the opposite, @LFO .
When you enable the filter, MIDI notes don’t pass thru. You have to disable the filter to get notes passing thru and reaching the chains.

Regards

[jofemodo]

@jofemodo

def process(frames):
            outport.clear_buffer()
            if self.filter_enabled.value:
               return
            for offset, indata in inport.incoming_midi_events():
                outport.write_midi_event(offset, indata)  # pass through
                # 3-bytes events
                if len(indata) == 3:
                    status, pitch, vel = struct.unpack('3B', indata)
                    # Note events in MIDI channel 1
                    if status >> 4 in (NOTEON, NOTEOFF) and (status & 0xF) == 0:
                        try:
                            outport.write_midi_event(offset, (status, pitch, vel))
                        except:
                            pass

Take a look to the code
BTW, you probably wat to route Pitch Bending events too.

Regards

[OutOfCheese]

The launchpad mini mk3 driver is mostly working (launching/stopping clips/“scenes” in session mode, playing notes in drums and keys tabs). The arrow keys only work in Session mode.

[jofemodo]

Hi @OutOfCheese !

Do you mean you tested the driver? AFAIK It’s fully working
What functionality you expect is not working?

Regards,

[OutOfCheese]

Hi jofemodo! Yes I tested to confirm it’s working. The arrow keys in note mode would be a nice feature but the device is usable as is, I’m sorry if I made the impression that it’s not.

Thanks for the awesome work on the drivers, it’s very much appreciated.

[LFO]

For some reason it appears jack is not available or not being imported or something. It’s underlined in VSCode, I get this error.

Traceback (most recent call last):
  File "/zynthian/venv/lib/python3.11/site-packages/jack.py", line 801, in callback_wrapper
    callback(frames)
  File "/zynthian/zynthian-ui/zyngine/ctrldev/zynthian_ctrldev_launchpad_pro_mk2.py", line 297, in process
    evtype = (indata[0] >> 4) & 0x0F
              ~~~~~~~~~~^^~~
TypeError: unsupported operand type(s) for >>: 'bytes' and 'int'

I’ll keep staring at jack examples but not having any success yet.

[jofemodo]

Hi @LFO!

I never used this VSCode thing. I try to avoid IDEs as they tend to confuse my limited mind

But python jack library is installed in your zynthian for sure and the error you are getting doesn’t seem like a dependency (library not found) issue.

The error message is pretty clear: You are using an operand “>>” that is not supported by the “bytes” type. You should do the proper data conversion.

Regards

[LFO]

Wow I’m surprised you don’t use an IDE! It can be confusing and helpful in equal measure for me.

It’s not in front of me now but when I fix the error above it tends to break something else. I’m sure it’s something simple but I find whatever I try, it bounces between these results:

• midi notes send to chain in all modes and UI control works (so for example launcher works but also sends notes)
• midi notes go to chain in note mode only and UI control is broken in other modes (launcher & device control don’t work)