I can’t access the repo. Link is broken and the repo seems to have vanished:
https://github.com/jlearman/stevie-clavinet
Cheers!
It’s there now. But let me add the package, I’m doing it now, among others (one at a time.)
No idea why the 404 earlier.
Not available from my location. The 404 persist. It seems a CDN issue.
Or perhaps you didn’t mark as “public” the repository?
Checking … thought that was the default.
Meanwhile, please see if you can merge my PR for Terkelsen Marimba. I just learned I need to create a branch to issue another PR for stevie-clavinet, until it’s merged.
Oops! It was private. It’s public now.
2 Likes
But sample rate conversion, thus resampling retaining pitch, is an extra step to resampling with altered pitch. But you’re right, it should have no problem with it.
1 Like
Once you convert to FFT you can do both conversions in one step, or at least, very cheaply. I doubt you’d be able to measure any CPU usage difference.
1 Like
Are we actually still into the idea of a “factory library” or are we fully going the package route?
The factory library would be a collection of packages 
There is a zynthian-factory-sfz package that is the “legacy factory library”. In the future this could be reduced or removed
2 Likes
I like this approach. First we can collect a bunch of packages, and later decide which ones should be new factory patches.
I don’t know how the full build is done now, but we could easily have a small repo that has a list of factory packages and a script, and then it’d be easy to install them all automatically as part of the build, and it’d also be easy to edit the list.
1 Like
Yes. That’s the idea. Modularity give us greater flexibility, and if we can organize management to be easy enough, i think we would be in the right way.
Regarding your PR, i just merged, but i had to fix some issues (you can check the later commits).
It’s clear we need a mechanism for testing packages before PR. And also a mechanims for validating PRs before merging. And of course, an “update mechanism” for packages
I’m thinking about it …
Ahh! The zip package for the marimba is not publicly available. I get 404. Are you sure about the URL? Have you tried to download without being logged in in github?
https://github.com/sfzinstruments/Terkelsen.Marimba/archive/refs/heads/main.zip
Regarding the Clavinet … ohhh yeahhhh!! It improves quite a bit what we had before, but, samples have some reverb embedded, right? Is it from a guitar amp used in conjunction with the clavinet? Or do you think it’s the “natural resonance” of the clavinet? I don’t think so …
Regards,
BTW, what about the Osiris piano?
Marimba: Maybe the URL changes when I set the repo public. I’ll check and update.
Clav: I enabled a little reverb in the sfz file. It sounded a bit dry without it, but I realize it’s better to let plugins do the reverb. LMK if you want me to remove it. If you want to, just change reverb_wet=10 to reverb_wet=0.
I’m trying to figure out how to have it controlled by CC91, but I haven’t had any response from the guys at sfz discord yet. The “normal way” doesn’t work, and I doubt I’d get any response at the sfizz github since it’s archived (ack.) What I’d like is to have the default be zero, but easily add reverb by passing CC91 and controlling it that way.
BTW, effects are one area where it’s different between sfizz and aria/Sforzando.
I’d forgotten about Osiris piano but noticed it when I went through my list of repos in case there was another one that was private that should be public. I’ll take a look soon.
I think public/private defaults to the last choice you made. All my repos had been public, but recently I made a private one to save my Linux home dir stuff.
Regarding a mechanism to test a package: I opened an issue to accept a URL, and I think that’d do it. Maybe with a checkbox for github URL with optional directory name in the repo. That way we could test with local filesystem directory, or a github project containing lots of packages.
Doh. The branch name for the marimba is master, not main.
It’s not possible, because the respective oncc opcodes for effects are not implemented i sfizz.
It’s a shame, but otherwise the reverb engines in zynthian are better anyway.
1 Like
Thanks. Too bad! I wonder how hard it’d be to add it. But, got enough on my plate for now.
I personally wouldn’t put a baked in static reverb there for zynthian use. Especially not for a clavinet.
1 Like
Right. It was for my own benefit, and I was hoping to change it to CC-controllable.
If Joe doesn’t disable the reverb in the clav, I will. But I’d like to leave the opcodes in there, just set to 0, for easy hacking.
1 Like
Wholeheartedly good luck for that. With my limited programming skills I once looked into the sfz parser code and finally gave up.
I was ambiguous. Re-read my post above, that I edited to actually communicate rather than blather.