I tested it with “Basic Sampler” of the organelle patches. In this patch the samplerate is already automatically adjusted to the systems samplerate.
Suggesting that playing the note C should deliver a pitch C. (Sample Speed knob to ORIG), I tried the following:
The original sample rate of the file was 44.1kHz, the pitch was a little too high.
I then resampled the 1.wav file in “recordings” directory to 48kHz (using sox), reloaded “Basic_Sampler” and the pitch was correct.
In the pd patch the file was read with soundfiler, if I understood the patch correctly. The sample rate information is not used in the patch. There has been no automatic resampling.
→ resample is IMO in most cases necessary to keep the same pitch as in original organelle patches.
Regards
@gitnob I really appreciate your thorough testing and suggested fixes. I don’t think changing the wav files to 48K will require that much additional work, as a script should find the 44.1K wav files and resample them to 48K. I’ll give it a go after I’m done with the other edits.
Ideally it would be nice to cover all of the bases for users using sample rates other than the default 48K in Zynthian, as well as covering possible changes to future standards. Editing the playback rates in the patches to scale the playback rate based on the system sample rate could be a monumental task. However, I haven’t really looked closely at that aspect of the patches to know for sure. I also haven’t checked to see just how many patches suffer from the pitch change. I know many are just sampled sounds, like percussive sounds, fx, etc. that don’t really require a pitch correction.
I will investigate when I finish with the task at hand. If you check into it further, please let me know your findings. Thank you for all of your help.