It’s helped to realise git & Github are different entities linked by a common approach.
A Pull Requests is a purely github mechanism that allows a trust web to be enforced.
Git just thinks about changes and not forgetting anything and the person managing the pull request concerns themselves with how appropriate it is within the environment.
It will then be escorted down into the deepest darkest dungeons to be submitted to unspeakable evils by the dark and ancient sages that drive this curse’d lands. . . .
Mostly, I blame LOTR and Terry Pratchett, mostly . . .
You don’t do a merge you are asking for one to be done on your behalf.
You make a Pull request and the prescribed God pulls it into the trunk, or doesn’t at their discretion.
Or rejects it with suggestions, reasons or nothing at all depending on the environment.
This is the way git works. You can fork to work on something then submit a pull request to off a patch to the upstream project. This allows anyone to work on their copy and submit changes without the main project having to grant unfettered access to everyone who wants to contrbute.
I have managed to add some (I hope) useful CUIAs to some buttons of the LP Pro MK3
I have no official Kit only a Pi4 ,a LCD HDMI screen, and I use the Headphone output of the Pi4
for audio (which ,by the way is to my 70 yo ears very good)
My ultimate goal is to be able to use only the LP Pro MK3 buttons and leave the mouse alone
I can easily have a pair of thin buttons act as Zynpot ( 0 1 2 and 3) with increment 1
but increment 1 is in some cases very (very) slow so I need to have a way to tell
“As long a button X+ is pressed (which emulates Zynpot X+) the parameter goes up
As long as button X- is pressed (which emulates Zynpot X-) the parameter goes down
Another problem I am facing is
It seems there is no CUIA for the MIDI Sustain function which is very useful in live recording with Zynseq , to add Chords or Long Notes , so I need to have one of the buttons send the correct
if ccnum == 0x65:
if ccval == 0x7F:
self.state_manager.send_cuia("GLU")
elif ccval == 0x00:
self.state_manager.send_cuia("GLO")
so I expect to have push button send CUIA: GLU and
release button send CUIA : GLO
the next step would be having a loop sending the same CUIA as long as the button is pressed and stopping when the button is released.
but in the logs I have
DEBUG:zynthian_ctrldev_launchpad_pro_mk3.midi_event: Launchpad Pro MK3 MIDI handler => b'\xb0e\x7f'
DEBUG:zynthian_gui.callable_ui_action: CUIA 'glu' => None
ERROR:zynthian_gui.callable_ui_action: Unknown CUIA 'glu'
DEBUG:zynthian_ctrldev_launchpad_pro_mk3.midi_event: Launchpad Pro MK3 MIDI handler => b'\xb0e\x00'
and that's all
so the MIDI code is received by Zynthian but is not translated into CUIA